Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676608

Mo Morsi <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
         AssignedTo|[email protected]    |[email protected]

--- Comment #1 from Mo Morsi <[email protected]> 2011-07-21 15:30:13 EDT ---
Taking this one. Overall looks good

- the latest upstream release is 2.1.4, please consider updating

- could you remove references in the summary / description to 'shopify'

- the rspec2 components are now in fedora, can we drop the patch to the spec
suite?

- there is one rpmlint warning to note:
rubygem-delayed_job.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/delayed_job-2.1.3/lib/generators/delayed_job/templates/script
0644L /usr/bin/env

- defaultattr is no longer necessary in files section an should be removed

- the package should own the %dir %{geminstdir} should it not


Package builds fine in koji.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to