Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=723756 --- Comment #3 from Jerry James <[email protected]> 2011-07-25 15:59:59 EDT --- Thanks for the review, Jon. (In reply to comment #1) > So, looks good, generally. I'm running a mock build to double-check BRs, and > I'm curious on your views vis-a-vis exit(). I agree. I hate it when library authors call exit(). I looked in the source code to see why this library does so. There is one call to exit(), in a function named fatal_error(). That function is called in the following situations: - a memory allocation failed - an internal assert()-like function failed - heap corruption was detected I'll talk to the upstream author about returning appropriate error codes instead of calling exit() in these situations. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
