Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=726210

--- Comment #3 from Tim Lauridsen <[email protected]> 2011-08-09 02:19:31 EDT ---
Issues:
[!] : MUST - Rpmlint output is silent.

        rpmlint freewrl-java-1.22.12-0.1.pre2.fc17.i686.rpm
       
================================================================================
        freewrl-java.i686: W: only-non-binary-in-usr-lib
        1 packages and 0 specfiles checked; 0 errors, 1 warnings.
       
================================================================================

        rpmlint libEAI-1.22.12-0.1.pre2.fc17.i686.rpm
       
================================================================================
        libEAI.i686: W: shared-lib-calls-exit /usr/lib/libFreeWRLEAI.so.1.22.12
exit@GLIBC_2.0
        1 packages and 0 specfiles checked; 0 errors, 1 warnings.
       
================================================================================
        I am not sure about this one


        rpmlint freewrl-1.22.12-0.1.pre2.fc17.src.rpm
       
================================================================================
        freewrl.src:120: E: hardcoded-library-path in
/usr/lib/jvm/java-openjdk/jre/lib/ext/vrml.jar
        1 packages and 0 specfiles checked; 1 errors, 0 warnings.
       
================================================================================
        This is ok, based on your comments

        rpmlint freewrl-debuginfo-1.22.12-0.1.pre2.fc17.i686.rpm
       
================================================================================
        1 packages and 0 specfiles checked; 0 errors, 0 warnings.
       
================================================================================

        rpmlint freewrl-devel-1.22.12-0.1.pre2.fc17.i686.rpm
       
================================================================================
        1 packages and 0 specfiles checked; 0 errors, 0 warnings.
       
================================================================================

        rpmlint libEAI-devel-1.22.12-0.1.pre2.fc17.i686.rpm
       
================================================================================
        libEAI-devel.i686: W: no-documentation
        1 packages and 0 specfiles checked; 0 errors, 1 warnings.
       
================================================================================
        OK

        rpmlint freewrl-1.22.12-0.1.pre2.fc17.i686.rpm
       
================================================================================
        freewrl.i686: W: no-manual-page-for-binary freewrl_msg
        freewrl.i686: W: no-manual-page-for-binary freewrl_snd
        1 packages and 0 specfiles checked; 0 errors, 2 warnings.
       
================================================================================
        OK

[!] : MUST - Development .so files in -devel subpackage, if present.
        freewrl-1.22.12-0.1.pre2.fc17.i686.rpm :
/usr/lib/mozilla/plugins/libFreeWRLplugin.so
        This is ok, it is a mozilla plugin

[!] : MUST - Sources used to build the package matches the upstream source, as
provided in the spec URL.
        /home/tim/tmp/reviewhelper/726210/freewrl-1.22.12_pre2.tar.bz2 :
          MD5SUM this package     : e9baa64e551483dbfcb21e879fdf0d8e
          MD5SUM upstream package : 7530cf536beade1cfbc4400c5725818d
        README.FreeWRL.java :
          MD5SUM this package     : e56065d5fc275961e6058540786d05fd
          MD5SUM upstream package : upstream source not found

      THis need to be fixed.

[!] : MUST - License file installed when any subpackage combination is
installed.
    libEAI subpackage don't require main package, so license file is not pulled
in.
      I think requiring the main package is needed here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to