Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=705363

--- Comment #9 from Petr Pisar <[email protected]> 2011-08-22 07:37:50 EDT ---
Source tar ball is original. Ok.

Spec file changes:

--- spacewalk-web.spec 2011-07-29 13:29:48.000000000 +0200
+++ spacewalk-web.spec.1 2011-08-19 13:40:05.000000000 +0200
@@ -2,9 +2,9 @@
 Summary: Spacewalk Web site - Perl modules
 Group: Applications/Internet
 License: GPLv2
-Version: 1.6.6
+Version: 1.6.14
 Release: 1%{?dist}
-URL:          https://fedorahosted.org/spacewalk
+URL:          https://fedorahosted.org/spacewalk/
 Source0:     
https://fedorahosted.org/releases/s/p/spacewalk/%{name}-%{version}.tar.gz
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) 
 BuildArch: noarch
@@ -54,11 +54,6 @@
 Summary: Core of Perl modules for %{name} package
 Group: Applications/Internet 
 Provides: spacewalk(spacewalk-base-minimal) = %{version}-%{release}
-%if 0%{?rhel} && 0%{?rhel} < 6
-Requires: tomcat5
-%else
-Requires: tomcat6
-%endif
 Requires: httpd
 Requires:  perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
 Obsoletes: rhn-base-minimal < 5.3.0
@@ -66,7 +61,7 @@

 %description -n spacewalk-base-minimal
 Independent Perl modules in the RHN:: name-space.
-This are very basic modules need to handle config files, database, sessions
+This are very basic modules need to handle configuration files, database,
sessions
 and exceptions.

 %package -n spacewalk-dobby
@@ -262,6 +257,36 @@

 # $Id$
 %changelog
+* Fri Aug 19 2011 Miroslav Suchý 1.6.14-1
+- 705363 - remove executable bit from modules and javascript
+- 705363 - Replace word "config" with "configuration" in
spacewalk-base-minimal
+  description
+- 705363 - normalize home page URL
+
+* Fri Aug 12 2011 Michael Mraka <[email protected]> 1.6.13-1
+- removed unnecessary join
+
+* Thu Aug 11 2011 Michael Mraka <[email protected]> 1.6.12-1
+- fixed couple more joins
+- removed typo parenthesis
+
+* Wed Aug 10 2011 Michael Mraka <[email protected]> 1.6.11-1
+- COALESCE works in both db backends
+
+* Wed Aug 10 2011 Michael Mraka <[email protected]> 1.6.10-1
+- replace oracle specific syntax with ANSI one
+- made NVL2 work in both db backends
+
+* Mon Aug 08 2011 Michael Mraka <[email protected]> 1.6.9-1
+- fixed re-activation key in PostgreSQL
+
+* Thu Aug 04 2011 Aron Parsons <[email protected]> 1.6.8-1
+- add support for custom messages in the header, footer and login pages
+  ([email protected])
+
+* Fri Jul 29 2011 Miroslav Suchý 1.6.7-1
+- Revert "adding tomcat require to spacewalk-base-minimal"
+
 * Fri Jul 29 2011 Miroslav Suchý 1.6.6-1
 - 705363 - remove obscure keys forgotten for ages
 - 705363 - Escape percentage symbol in changelog


> TODO: Normalize home page URL. I.e. append slash.
-URL:          https://fedorahosted.org/spacewalk
+URL:          https://fedorahosted.org/spacewalk/
Ok.

> TODO: Correct Source0 URL if possible. The file
> (https://fedorahosted.org/releases/s/p/spacewalk/spacewalk-web-1.6.6.tar.gz)
> does not exist at the location.
Tar ball available now. Ok.

> FIX: Replace word `config' with `configuration' in spacewalk-base-minimal
> description.
 %description -n spacewalk-base-minimal
 Independent Perl modules in the RHN:: name-space.
-This are very basic modules need to handle config files, database, sessions
+This are very basic modules need to handle configuration files, database,
sessions
Ok.

> FIX: Remove executable bit from /var/www/html/javascript/* files as they are
> not intended to be executed by kernel/linker.
Ok.

> FIX: Correct mode (0644) for files in /usr/share/perl5/vendor_perl/Sniglets/
> as they are interpreted libraries.
Ok.


Re-review of 1.6.14 follows:

$ rpmlint spacewalk-web.spec ../SRPMS/spacewalk-web-1.6.14-1.fc15.src.rpm
../RPMS/noarch/spacewalk-*1.6.14-*
spacewalk-base-minimal.noarch: E: description-line-too-long C This are very
basic modules need to handle configuration files, database, sessions
spacewalk-base-minimal.noarch: W: conffile-without-noreplace-flag
/etc/rhn/default/rhn_web.conf
spacewalk-base-minimal.noarch: E: non-readable /etc/rhn/default/rhn_web.conf
0640L
spacewalk-dobby.noarch: W: conffile-without-noreplace-flag
/etc/rhn/default/rhn_dobby.conf
spacewalk-dobby.noarch: E: non-readable /etc/rhn/default/rhn_dobby.conf 0640L
spacewalk-grail.noarch: W: no-documentation
spacewalk-pxt.noarch: W: spelling-error Summary(en_US) templating ->
contemplating, tempting, template
spacewalk-pxt.noarch: W: conffile-without-noreplace-flag
/etc/rhn/default/rhn_web.conf
spacewalk-pxt.noarch: E: non-readable /etc/rhn/default/rhn_web.conf 0640L
spacewalk-sniglets.noarch: W: no-documentation
8 packages and 1 specfiles checked; 4 errors, 6 warnings.

Configuration files accepted per review submission.

FIX: Reformat description text for spacewalk-base-minimal not to exceed 80
columns.

Otherwise rpmlint is Ok.

License verified from various Perl modules and javascript sources. Ok.
No XS code. noarch architecture is Ok.

Files layout and permissions are Ok, except the issue with
/usr/share/perl5/vendor_perl/PXT/Config.pm:

> > Notice: perl(PXT::Config) (and /usr/share/perl5/vendor_perl/PXT/Config.pm)
> > is provided by two packages: spacewalk-base-minimal and spacewalk-pxt.
> > Is it intentional?
>
> Yes, it is intentional. PXT is quite standalone (but still part of Spacewalk
> and primary developed for spacewalk) so it is included directly in that
> sub-package and we do not want to force potential user to install
> spacewalk-base.
> On the other hand we need PXT/Config.pm on Spacewalk proxy and to read
> monitoring configuration files, but we do not need there whole PXT. Therefore
> it is packaged in -minimal sub-package together with additional essential
> files.

Fedora packaging guidelines forbids sharing files between packages
<https://fedoraproject.org/wiki/Packaging/Guidelines#Duplicate_Files>.

FIX: I recommend to split the /usr/share/perl5/vendor_perl/PXT/Config.pm file
into new sub-package and make this sub-package required by
spacewalk-base-minimal and spacewalk-pxt. Otherwise make the two packages
mutually exclusive, or ask Fedora Packaging Committee for exception.


Binary requires:

../RPMS/noarch/spacewalk-base-minimal-1.6.14-1.fc15.noarch.rpm
      1 config(spacewalk-base-minimal) = 1.6.14-1.fc15
      1 httpd  
      1 perl(Carp)  
      1 perl(DBI)  
      1 perl(Digest::HMAC_SHA1)  
      1 perl(Digest::MD5)  
      1 perl(Exporter)  
      1 perl(:MODULE_COMPAT_5.12.4)  
      1 perl(overload)  
      1 perl(Params::Validate)  
      1 perl(PXT::Config)  
      1 perl(RHN::Exception)  
      1 perl(Scalar::Util)  
      1 perl(strict)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
../RPMS/noarch/spacewalk-base-1.6.14-1.fc15.noarch.rpm
      1 perl(Apache2::RequestUtil)  
      1 perl(Archive::Tar)  
      1 perl(Authen::PAM)  
      1 perl(base)  
      1 perl(Carp)  
      1 perl(constant)  
      1 perl(Data::Dumper)  
      1 perl(Date::Parse)  
      1 perl(DateTime)  
      1 perl(Digest::MD5)  
      1 perl(English)  
      1 perl(File::Spec)  
      1 perl(File::Temp)  
      1 perl(Frontier::Client)  
      1 perl(IO::File)  
      1 perl(IO::Socket::INET)  
      1 perl(IPC::Open3)  
      1 perl(lib)  
      1 perl(LWP::UserAgent)  
      1 perl(Mail::RFC822::Address)  
      1 perl(MIME::Base64)  
      1 perl(ModPerl::Util)  
      1 perl(:MODULE_COMPAT_5.12.4)  
      1 perl(NOCpulse::Config)  
      1 perl(overload)  
      1 perl(Params::Validate)  
      1 perl(POSIX)  
      1 perl(PXT::ACL)  
      1 perl(PXT::Config)  
      1 perl(PXT::Debug)  
      1 perl(PXT::HTML)  
      1 perl(PXT::Parser)  
      1 perl(PXT::Utils)  
      1 perl(RHN::Access)  
      1 perl(RHN::Action)  
      1 perl(RHN::AppInstall::ACL)  
      1 perl(RHN::AppInstall::ActionHandler)  
      1 perl(RHN::AppInstall::ActionHandler::ActionRunner)  
      1 perl(RHN::AppInstall::ActionHandler::ActionScheduler)  
      1 perl(RHN::AppInstall::Instance)  
      1 perl(RHN::AppInstall::Process)  
      1 perl(RHN::AppInstall::Process::Configure)  
      1 perl(RHN::AppInstall::Process::Install)  
      1 perl(RHN::AppInstall::Process::InstallProgress)  
      1 perl(RHN::AppInstall::Process::Remove)  
      1 perl(RHN::AppInstall::Process::Step)  
      1 perl(RHN::AppInstall::Process::Step::Action)  
      1 perl(RHN::AppInstall::Process::Step::Action::Arg)  
      1 perl(RHN::AppInstall::Process::Step::ActionStatus)  
      1 perl(RHN::AppInstall::Process::Step::ActionStatus::Action)  
      1 perl(RHN::AppInstall::Process::Step::Activity)  
      1 perl(RHN::AppInstall::Process::Step::Activity::Action)  
      1 perl(RHN::AppInstall::Process::Step::CollectData)  
      1 perl(RHN::AppInstall::Process::Step::Redirect)  
      1 perl(RHN::AppInstall::Process::Step::Requirements)  
      1 perl(RHN::AppInstall::Process::Step::ScheduleActions)  
      1 perl(RHN::AppInstall::Process::Step::ScheduleActions::Action)  
      1 perl(RHN::AppInstall::Replace)  
      1 perl(RHN::AppInstall::RequirementHandler)  
      1 perl(RHN::AppInstall::Session)  
      1 perl(RHN::AppInstall::Session::Access)  
      1 perl(RHN::Cache::File)  
      1 perl(RHN::Cert)  
      1 perl(RHN::ConfigChannel)  
      1 perl(RHN::ConfigRevision)  
      1 perl(RHN::ContactGroup)  
      1 perl(RHN::CryptoKey)  
      1 perl(RHN::CustomInfoKey)  
      1 perl(RHN::DataSource)  
      1 perl(RHN::DataSource::Action)  
      1 perl(RHN::DataSource::ConfigChannel)  
      1 perl(RHN::DataSource::ContactMethod)  
      1 perl(RHN::DataSource::Errata)  
      1 perl(RHN::DataSource::General)  
      1 perl(RHN::DataSource::Channel)  
      1 perl(RHN::DataSource::Package)  
      1 perl(RHN::DataSource::Simple)  
      1 perl(RHN::DataSource::System)  
      1 perl(RHN::DataSource::SystemGroup)  
      1 perl(RHN::Date)  
      1 perl(RHN::DB)  
      1 perl(RHN::DB::Action)  
      1 perl(RHN::DB::AppInstall::Instance)  
      1 perl(RHN::DB::AppInstall::Session)  
      1 perl(RHN::DB::ConfigChannel)  
      1 perl(RHN::DB::ConfigRevision)  
      1 perl(RHN::DB::ContactGroup)  
      1 perl(RHN::DB::ContactMethod)  
      1 perl(RHN::DB::CryptoKey)  
      1 perl(RHN::DB::CustomInfoKey)  
      1 perl(RHN::DB::DataSource)  
      1 perl(RHN::DB::Entitlements)  
      1 perl(RHN::DB::Errata)  
      1 perl(RHN::DB::ErrataEditor)  
      1 perl(RHN::DB::ErrataTmp)  
      1 perl(RHN::DB::FileList)  
      1 perl(RHN::DB::Channel)  
      1 perl(RHN::DB::ChannelEditor)  
      1 perl(RHN::DB::JoinClass)  
      1 perl(RHN::DB::Kickstart)  
      1 perl(RHN::DB::Kickstart::Session)  
      1 perl(RHN::DB::KSTree)  
      1 perl(RHN::DB::Notes)  
      1 perl(RHN::DB::Org)  
      1 perl(RHN::DB::Package)  
      1 perl(RHN::DB::Package::SolarisPackage)  
      1 perl(RHN::DB::Package::SolarisPatch)  
      1 perl(RHN::DB::Package::SolarisPatchSet)  
      1 perl(RHN::DB::Profile)  
      1 perl(RHN::DB::SatCluster)  
      1 perl(RHN::DB::SatInstall)  
      1 perl(RHN::DB::Server)  
      1 perl(RHN::DB::ServerActions)  
      1 perl(RHN::DB::Server::CdDevice)  
      1 perl(RHN::DB::ServerGroup)  
      1 perl(RHN::DB::Server::HwDevice)  
      1 perl(RHN::DB::Server::NetInfo)  
      1 perl(RHN::DB::Server::NetInterface)  
      1 perl(RHN::DB::Server::StorageDevice)  
      1 perl(RHN::DB::Set)  
      1 perl(RHN::DB::Scheduler)  
      1 perl(RHN::DB::SystemSnapshot)  
      1 perl(RHN::DB::TableClass)  
      1 perl(RHN::DB::Tag)  
      1 perl(RHN::DB::TemplateString)  
      1 perl(RHN::DB::TinyURL)  
      1 perl(RHN::DB::Token)  
      1 perl(RHN::DB::User)  
      1 perl(RHN::Entitlements)  
      1 perl(RHN::Errata)  
      1 perl(RHN::ErrataEditor)  
      1 perl(RHN::ErrataTmp)  
      1 perl(RHN::Exception)  
      1 perl(RHN::FileList)  
      1 perl(RHN::Form)  
      1 perl(RHN::Form::Filter)  
      1 perl(RHN::Form::NamespaceForm)  
      1 perl(RHN::Form::ParsedForm)  
      1 perl(RHN::Form::Parser)  
      1 perl(RHN::Form::RealizedForm)  
      1 perl(RHN::Form::Require)  
      1 perl(RHN::Form::Response)  
      1 perl(RHN::Form::Widget)  
      1 perl(RHN::Form::Widget::File)  
      1 perl(RHN::Form::Widget::Hidden)  
      1 perl(RHN::Form::Widget::Checkbox)  
      1 perl(RHN::Form::Widget::CheckboxGroup)  
      1 perl(RHN::Form::Widget::Literal)  
      1 perl(RHN::Form::Widget::Password)  
      1 perl(RHN::Form::Widget::RadiobuttonGroup)  
      1 perl(RHN::Form::Widget::Select)  
      1 perl(RHN::Form::Widget::Submit)  
      1 perl(RHN::Form::Widget::Text)  
      1 perl(RHN::Form::Widget::TextArea)  
      1 perl(RHN::Channel)  
      1 perl(RHN::ChannelEditor)  
      1 perl(RHN::Kickstart::Commands)  
      1 perl(RHN::Kickstart::Include)  
      1 perl(RHN::Kickstart::IPAddress)  
      1 perl(RHN::Kickstart::IPRange)  
      1 perl(RHN::Kickstart::Logvols)  
      1 perl(RHN::Kickstart::Multi)  
      1 perl(RHN::Kickstart::Packages)  
      1 perl(RHN::Kickstart::Partitions)  
      1 perl(RHN::Kickstart::Password)  
      1 perl(RHN::Kickstart::Post)  
      1 perl(RHN::Kickstart::Pre)  
      1 perl(RHN::Kickstart::Raids)  
      1 perl(RHN::Kickstart::Session)  
      1 perl(RHN::Kickstart::Volgroups)  
      1 perl(RHN::KSTree)  
      1 perl(RHN::Mail)  
      1 perl(RHN::Manifest)  
      1 perl(RHN::Org)  
      1 perl(RHN::Package)  
      1 perl(RHN::Package::SolarisPackage)  
      1 perl(RHN::Package::SolarisPatch)  
      1 perl(RHN::Package::SolarisPatchSet)  
      1 perl(RHN::Profile)  
      1 perl(RHN::SatCluster)  
      1 perl(RHN::SatelliteCert)  
      1 perl(RHN::SatInstall)  
      1 perl(RHN::SearchType)  
      1 perl(RHN::Server)  
      1 perl(RHN::SessionSwap)  
      1 perl(RHN::Set)  
      1 perl(RHN::Scheduler)  
      1 perl(RHN::SimpleStruct)  
      1 perl(RHN::SystemSnapshot)  
      1 perl(RHN::Tag)  
      1 perl(RHN::TemplateString)  
      1 perl(RHN::Token)  
      1 perl(RHN::User)  
      1 perl(RHN::Utils)  
      1 perl(RPM2)  
      1 perl(Scalar::Util)  
      1 perl(Socket)  
      1 perl(Storable)  
      1 perl(strict)  
      1 perl(Text::Wrap)  
      1 perl(Time::HiRes)  
      1 perl(URI::URL)  
      1 perl(vars)  
      1 perl(XML::LibXML)  
      1 perl(XML::LibXML) >= 1.53
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 spacewalk-pxt  
      1 webserver  
../RPMS/noarch/spacewalk-dobby-1.6.14-1.fc15.noarch.rpm
      1 /bin/bash  
      1 config(spacewalk-dobby) = 1.6.14-1.fc15
      1 httpd  
      1 perl(Carp)  
      1 perl(Compress::Zlib)  
      1 perl(Digest::MD5)  
      1 perl(Dobby::BackupLog)  
      1 perl(Dobby::CLI)  
      1 perl(Dobby::CLI::BackupCommands)  
      1 perl(Dobby::CLI::MaintCommands)  
      1 perl(Dobby::CLI::MiscCommands)  
      1 perl(Dobby::DB)  
      1 perl(Dobby::Files)  
      1 perl(Dobby::Log)  
      1 perl(Dobby::Reporting)  
      1 perl(Fcntl)  
      1 perl(File::Basename)  
      1 perl(File::Spec)  
      1 perl(File::Spec::Functions)  
      1 perl(Filesys::Df)  
      1 perl(IO::Handle)  
      1 perl(IO::Select)  
      1 perl(IPC::Open2)  
      1 perl(:MODULE_COMPAT_5.12.4)  
      1 perl(Params::Validate)  
      1 perl(POSIX)  
      1 perl(PXT::Config)  
      1 perl(RHN::DB)  
      1 perl(RHN::SimpleStruct)  
      1 perl(Storable)  
      1 perl(strict)  
      1 perl(XML::LibXML)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 spacewalk-base  
      1 /usr/bin/perl  
../RPMS/noarch/spacewalk-grail-1.6.14-1.fc15.noarch.rpm
      1 perl(Carp)  
      1 perl(Grail::Canvas)  
      1 perl(Grail::Component)  
      1 perl(:MODULE_COMPAT_5.12.4)  
      1 perl(PXT::Utils)  
      1 perl(strict)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 spacewalk-base  
../RPMS/noarch/spacewalk-html-1.6.14-1.fc15.noarch.rpm
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 spacewalk-branding  
      1 webserver  
../RPMS/noarch/spacewalk-pxt-1.6.14-1.fc15.noarch.rpm
      1 config(spacewalk-pxt) = 1.6.14-1.fc15
      1 httpd  
      1 perl(Apache2::Access)  
      1 perl(Apache2::Connection)  
      1 perl(Apache2::Const)  
      1 perl(Apache2::Cookie)  
      1 perl(Apache2::Log)  
      1 perl(Apache2::Request)  
      1 perl(Apache2::RequestIO)  
      1 perl(Apache2::RequestUtil)  
      1 perl(Apache2::ServerUtil)  
      1 perl(Apache2::SubRequest)  
      1 perl(Apache2::URI)  
      1 perl(Apache2::Util)  
      1 perl(APR::URI)  
      1 perl(BSD::Resource)  
      1 perl(bytes)  
      1 perl(Cache::FileCache)  
      1 perl(Carp)  
      1 perl(Compress::Zlib)  
      1 perl(constant)  
      1 perl(Data::Dumper)  
      1 perl(Date::Parse)  
      1 perl(File::Spec)  
      1 perl(HTML::Entities)  
      1 perl(:MODULE_COMPAT_5.12.4)  
      1 perl(Params::Validate)  
      1 perl(POSIX)  
      1 perl(PXT::ACL)  
      1 perl(PXT::ApacheHandler)  
      1 perl(PXT::Config)  
      1 perl(PXT::Debug)  
      1 perl(PXT::Handlers)  
      1 perl(PXT::Parser)  
      1 perl(PXT::Request)  
      1 perl(PXT::Trace)  
      1 perl(PXT::Utils)  
      1 perl(RHN::Access)  
      1 perl(RHN::Cleansers)  
      1 perl(RHN::DB)  
      1 perl(RHN::Exception)  
      1 perl(RHN::I18N)  
      1 perl(RHN::Mail)  
      1 perl(RHN::Session)  
      1 perl(RHN::StoredMessage)  
      1 perl(RHN::User)  
      1 perl(Scalar::Util)  
      1 perl(strict)  
      1 perl(Sys::Hostname)  
      1 perl(Time::HiRes)  
      1 perl(URI::URL)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 spacewalk(spacewalk-base-minimal)  
../RPMS/noarch/spacewalk-sniglets-1.6.14-1.fc15.noarch.rpm
      1 perl(base)  
      1 perl(Carp)  
      1 perl(Class::Struct)  
      1 perl(constant)  
      1 perl(Data::Dumper)  
      1 perl(Date::Parse)  
      1 perl(Digest::MD5)  
      1 perl(File::Spec)  
      1 perl(Mail::RFC822::Address)  
      1 perl(:MODULE_COMPAT_5.12.4)  
      1 perl(Params::Validate)  
      1 perl(POSIX)  
      1 perl(PXT::ACL)  
      1 perl(PXT::Config)  
      1 perl(PXT::HTML)  
      1 perl(PXT::Trace)  
      1 perl(PXT::Utils)  
      1 perl(RHN::Access)  
      1 perl(RHN::Action)  
      1 perl(RHN::AppInstall::Parser)  
      1 perl(RHN::AppInstall::Process::Step::ScheduleActions)  
      1 perl(RHN::AppInstall::Session)  
      1 perl(RHN::ConfigChannel)  
      1 perl(RHN::ConfigRevision)  
      1 perl(RHN::ContactGroup)  
      1 perl(RHN::ContactMethod)  
      1 perl(RHN::CustomInfoKey)  
      1 perl(RHN::DataSource)  
      1 perl(RHN::DataSource::Action)  
      1 perl(RHN::DataSource::ConfigChannel)  
      1 perl(RHN::DataSource::ContactMethod)  
      1 perl(RHN::DataSource::CustomInfo)  
      1 perl(RHN::DataSource::Errata)  
      1 perl(RHN::DataSource::General)  
      1 perl(RHN::DataSource::Channel)  
      1 perl(RHN::DataSource::Package)  
      1 perl(RHN::DataSource::Probe)  
      1 perl(RHN::DataSource::Scout)  
      1 perl(RHN::DataSource::Simple)  
      1 perl(RHN::DataSource::System)  
      1 perl(RHN::DataSource::SystemGroup)  
      1 perl(RHN::DataSource::User)  
      1 perl(RHN::Date)  
      1 perl(RHN::DB)  
      1 perl(RHN::DB::SatCluster)  
      1 perl(RHN::Entitlements)  
      1 perl(RHN::Errata)  
      1 perl(RHN::ErrataTmp)  
      1 perl(RHN::Exception)  
      1 perl(RHN::Form)  
      1 perl(RHN::Form::ParsedForm)  
      1 perl(RHN::Form::Widget::Hidden)  
      1 perl(RHN::Form::Widget::Checkbox)  
      1 perl(RHN::Form::Widget::CheckboxGroup)  
      1 perl(RHN::Form::Widget::Literal)  
      1 perl(RHN::Form::Widget::Select)  
      1 perl(RHN::Form::Widget::Submit)  
      1 perl(RHN::Channel)  
      1 perl(RHN::ChannelEditor)  
      1 perl(RHN::Kickstart)  
      1 perl(RHN::Kickstart::Session)  
      1 perl(RHN::Mail)  
      1 perl(RHN::Manifest)  
      1 perl(RHN::Org)  
      1 perl(RHN::Package)  
      1 perl(RHN::Postal)  
      1 perl(RHN::Profile)  
      1 perl(RHN::SatCluster)  
      1 perl(RHN::SatelliteCert)  
      1 perl(RHN::SatInstall)  
      1 perl(RHN::SearchTypes)  
      1 perl(RHN::Server)  
      1 perl(RHN::ServerActions)  
      1 perl(RHN::ServerGroup)  
      1 perl(RHN::ServerNotes)  
      1 perl(RHN::Set)  
      1 perl(RHN::Scheduler)  
      1 perl(RHN::SystemSnapshot)  
      1 perl(RHN::TemplateString)  
      1 perl(RHN::TinyURL)  
      1 perl(RHN::Token)  
      1 perl(RHN::User)  
      1 perl(RHN::Utils)  
      1 perl(Sniglets::ActivationKeys)  
      1 perl(Sniglets::AppInstall)  
      1 perl(Sniglets::Forms)  
      1 perl(Sniglets::Forms::Style)  
      1 perl(Sniglets::Forms::Style::standard)  
      1 perl(Sniglets::HTML)  
      1 perl(Sniglets::Channel)  
      1 perl(Sniglets::Lists)  
      1 perl(Sniglets::ListView::ConfigChannelList)  
      1 perl(Sniglets::ListView::ErrataList)  
      1 perl(Sniglets::ListView::ExtraClasses)  
      1 perl(Sniglets::ListView::FileList)  
      1 perl(Sniglets::ListView::GeneralList)  
      1 perl(Sniglets::ListView::ChannelList)  
      1 perl(Sniglets::ListView::List)  
      1 perl(Sniglets::ListView::PackageList)  
      1 perl(Sniglets::ListView::Parser)  
      1 perl(Sniglets::ListView::ProbeList)  
      1 perl(Sniglets::ListView::Style)  
      1 perl(Sniglets::ListView::Style::blank)  
      1 perl(Sniglets::ListView::SystemGroupList)  
      1 perl(Sniglets::ListView::SystemList)  
      1 perl(Sniglets::ListView::UserList)  
      1 perl(Sniglets::Navi::Node)  
      1 perl(Sniglets::Navi::Parser)  
      1 perl(Sniglets::Navi::Style)  
      1 perl(Sniglets::Navi::Style::ul)  
      1 perl(Sniglets::Navi::Tree)  
      1 perl(Sniglets::Packages)  
      1 perl(Sniglets::Search)  
      1 perl(Sniglets::ServerActions)  
      1 perl(Sniglets::ServerGroup)  
      1 perl(Sniglets::Servers)  
      1 perl(strict)  
      1 perl(URI)  
      1 perl(XML::LibXML)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

Binary provides:

../RPMS/noarch/spacewalk-base-minimal-1.6.14-1.fc15.noarch.rpm
      1 config(spacewalk-base-minimal) = 1.6.14-1.fc15
      1 perl(PXT::Config)  
      1 perl(RHN::DB)  
      1 perl(RHN::DB::db)  
      1 perl(RHN::DB::st)  
      1 perl(RHN::Exception)  
      1 perl(RHN::Exception::DB)  
      1 perl(RHN::SessionSwap)  
      1 rhn-base-minimal = 5.3.0
      1 spacewalk-base-minimal = 1.6.14-1.fc15
      1 spacewalk(spacewalk-base-minimal) = 1.6.14-1.fc15
../RPMS/noarch/spacewalk-base-1.6.14-1.fc15.noarch.rpm
      1 perl(RHN::Access)  
      1 perl(RHN::Access::Action)  
      1 perl(RHN::Access::Channel)  
      1 perl(RHN::Access::Package)  
      1 perl(RHN::Access::System)  
      1 perl(RHN::Access::Token)  
      1 perl(RHN::Action)  
      1 perl(RHN::AppInstall::ACL)  
      1 perl(RHN::AppInstall::ActionHandler)  
      1 perl(RHN::AppInstall::ActionHandler::ActionRunner)  
      1 perl(RHN::AppInstall::ActionHandler::ActionScheduler)  
      1 perl(RHN::AppInstall::Instance)  
      1 perl(RHN::AppInstall::Parser)  
      1 perl(RHN::AppInstall::Process)  
      1 perl(RHN::AppInstall::Process::Configure)  
      1 perl(RHN::AppInstall::Process::Install)  
      1 perl(RHN::AppInstall::Process::InstallProgress)  
      1 perl(RHN::AppInstall::Process::Remove)  
      1 perl(RHN::AppInstall::Process::Step)  
      1 perl(RHN::AppInstall::Process::Step::Action)  
      1 perl(RHN::AppInstall::Process::Step::Action::Arg)  
      1 perl(RHN::AppInstall::Process::Step::ActionStatus)  
      1 perl(RHN::AppInstall::Process::Step::ActionStatus::Action)  
      1 perl(RHN::AppInstall::Process::Step::Activity)  
      1 perl(RHN::AppInstall::Process::Step::Activity::Action)  
      1 perl(RHN::AppInstall::Process::Step::CollectData)  
      1 perl(RHN::AppInstall::Process::Step::Redirect)  
      1 perl(RHN::AppInstall::Process::Step::Requirements)  
      1 perl(RHN::AppInstall::Process::Step::ScheduleActions)  
      1 perl(RHN::AppInstall::Process::Step::ScheduleActions::Action)  
      1 perl(RHN::AppInstall::Replace)  
      1 perl(RHN::AppInstall::RequirementHandler)  
      1 perl(RHN::AppInstall::Session)  
      1 perl(RHN::AppInstall::Session::Access)  
      1 perl(RHN::Cache::File)  
      1 perl(RHN::Cert)  
      1 perl(RHN::Cleansers)  
      1 perl(RHN::ConfigChannel)  
      1 perl(RHN::ConfigRevision)  
      1 perl(RHN::ContactGroup)  
      1 perl(RHN::ContactMethod)  
      1 perl(RHN::CryptoKey)  
      1 perl(RHN::CustomInfoKey)  
      1 perl(RHN::DataSource)  
      1 perl(RHN::DataSource::Action)  
      1 perl(RHN::DataSource::ConfigChannel)  
      1 perl(RHN::DataSource::ContactMethod)  
      1 perl(RHN::DataSource::CustomInfo)  
      1 perl(RHN::DataSource::Errata)  
      1 perl(RHN::DataSource::General)  
      1 perl(RHN::DataSource::Channel)  
      1 perl(RHN::DataSource::Package)  
      1 perl(RHN::DataSource::Probe)  
      1 perl(RHN::DataSource::Scout)  
      1 perl(RHN::DataSource::Simple)  
      1 perl(RHN::DataSource::System)  
      1 perl(RHN::DataSource::SystemGroup)  
      1 perl(RHN::DataSource::User)  
      1 perl(RHN::Date)  
      1 perl(RHN::DB::Action)  
      1 perl(RHN::DB::AppInstall::Instance)  
      1 perl(RHN::DB::AppInstall::Session)  
      1 perl(RHN::DB::ConfigChannel)  
      1 perl(RHN::DB::ConfigRevision)  
      1 perl(RHN::DB::ContactGroup)  
      1 perl(RHN::DB::ContactMethod)  
      1 perl(RHN::DB::CryptoKey)  
      1 perl(RHN::DB::CustomInfoKey)  
      1 perl(RHN::DB::DataSource)  
      1 perl(RHN::DB::Entitlements)  
      1 perl(RHN::DB::Errata)  
      1 perl(RHN::DB::ErrataEditor)  
      1 perl(RHN::DB::ErrataTmp)  
      1 perl(RHN::DB::FileList)  
      1 perl(RHN::DB::Channel)  
      1 perl(RHN::DB::ChannelEditor)  
      1 perl(RHN::DB::JoinClass)  
      1 perl(RHN::DB::Kickstart)  
      1 perl(RHN::DB::Kickstart::Session)  
      1 perl(RHN::DB::KSTree)  
      1 perl(RHN::DB::Notes)  
      1 perl(RHN::DB::Org)  
      1 perl(RHN::DB::Package)  
      1 perl(RHN::DB::Package::SolarisPackage)  
      1 perl(RHN::DB::Package::SolarisPatch)  
      1 perl(RHN::DB::Package::SolarisPatchSet)  
      1 perl(RHN::DB::Profile)  
      1 perl(RHN::DB::SatCluster)  
      1 perl(RHN::DB::SatInstall)  
      1 perl(RHN::DB::Server)  
      1 perl(RHN::DB::ServerActions)  
      1 perl(RHN::DB::Server::CdDevice)  
      1 perl(RHN::DB::ServerGroup)  
      1 perl(RHN::DB::Server::HwDevice)  
      1 perl(RHN::DB::Server::NetInfo)  
      1 perl(RHN::DB::Server::NetInterface)  
      1 perl(RHN::DB::Server::StorageDevice)  
      1 perl(RHN::DB::Set)  
      1 perl(RHN::DB::Scheduler)  
      1 perl(RHN::DB::SystemSnapshot)  
      1 perl(RHN::DB::TableClass)  
      1 perl(RHN::DB::Tag)  
      1 perl(RHN::DB::TemplateString)  
      1 perl(RHN::DB::TinyURL)  
      1 perl(RHN::DB::Token)  
      1 perl(RHN::DB::User)  
      1 perl(RHN::Entitlements)  
      1 perl(RHN::Errata)  
      1 perl(RHN::ErrataEditor)  
      1 perl(RHN::ErrataTmp)  
      1 perl(RHN::FileList)  
      1 perl(RHN::Form)  
      1 perl(RHN::Form::Filter)  
      1 perl(RHN::Form::NamespaceForm)  
      1 perl(RHN::Form::ParsedForm)  
      1 perl(RHN::Form::Parser)  
      1 perl(RHN::Form::RealizedForm)  
      1 perl(RHN::Form::Require)  
      1 perl(RHN::Form::Response)  
      1 perl(RHN::Form::Widget)  
      1 perl(RHN::Form::Widget::File)  
      1 perl(RHN::Form::Widget::Hidden)  
      1 perl(RHN::Form::Widget::Checkbox)  
      1 perl(RHN::Form::Widget::CheckboxGroup)  
      1 perl(RHN::Form::Widget::Literal)  
      1 perl(RHN::Form::Widget::Multiple)  
      1 perl(RHN::Form::Widget::Password)  
      1 perl(RHN::Form::Widget::RadiobuttonGroup)  
      1 perl(RHN::Form::Widget::Select)  
      1 perl(RHN::Form::Widget::Spacer)  
      1 perl(RHN::Form::Widget::Submit)  
      1 perl(RHN::Form::Widget::Text)  
      1 perl(RHN::Form::Widget::TextArea)  
      1 perl(RHN::Channel)  
      1 perl(RHN::ChannelEditor)  
      1 perl(RHN::I18N)  
      1 perl(RHN::Kickstart)  
      1 perl(RHN::Kickstart::Commands)  
      1 perl(RHN::Kickstart::Include)  
      1 perl(RHN::Kickstart::IPAddress)  
      1 perl(RHN::Kickstart::IPRange)  
      1 perl(RHN::Kickstart::Logvols)  
      1 perl(RHN::Kickstart::Multi)  
      1 perl(RHN::Kickstart::Packages)  
      1 perl(RHN::Kickstart::Partitions)  
      1 perl(RHN::Kickstart::Password)  
      1 perl(RHN::Kickstart::Post)  
      1 perl(RHN::Kickstart::Pre)  
      1 perl(RHN::Kickstart::Raids)  
      1 perl(RHN::Kickstart::Session)  
      1 perl(RHN::Kickstart::Volgroups)  
      1 perl(RHN::KSTree)  
      1 perl(RHN::Mail)  
      1 perl(RHN::Manifest)  
      1 perl(RHN::Manifest::Package)  
      1 perl(RHN::Org)  
      1 perl(RHN::Package)  
      1 perl(RHN::Package::SolarisPackage)  
      1 perl(RHN::Package::SolarisPatch)  
      1 perl(RHN::Package::SolarisPatchSet)  
      1 perl(RHN::Postal)  
      1 perl(RHN::Profile)  
      1 perl(RHN::ProxyInstall)  
      1 perl(RHN::SatCluster)  
      1 perl(RHN::SatelliteCert)  
      1 perl(RHN::SatInstall)  
      1 perl(RHN::SCDB)  
      1 perl(RHN::SearchType)  
      1 perl(RHN::SearchTypes)  
      1 perl(RHN::SearchType::System)  
      1 perl(RHN::Server)  
      1 perl(RHN::ServerActions)  
      1 perl(RHN::ServerEvent)  
      1 perl(RHN::ServerEvent::ConfigDeploy)  
      1 perl(RHN::ServerEvent::ConfigDiff)  
      1 perl(RHN::ServerEvent::ConfigUpload)  
      1 perl(RHN::ServerEvent::DeltaTransaction)  
      1 perl(RHN::ServerEvent::ErrataUpdate)  
      1 perl(RHN::ServerEvent::History)  
      1 perl(RHN::ServerEvent::PackageAction)  
      1 perl(RHN::ServerEvent::PackageRemove)  
      1 perl(RHN::ServerEvent::PackageRemove::Solaris)  
      1 perl(RHN::ServerEvent::PackageUpdate)  
      1 perl(RHN::ServerEvent::PackageUpdate::Solaris)  
      1 perl(RHN::ServerEvent::PackageVerify)  
      1 perl(RHN::ServerEvent::RemoteCommand)  
      1 perl(RHN::ServerEvent::SimpleAction)  
      1 perl(RHN::ServerGroup)  
      1 perl(RHN::ServerNotes)  
      1 perl(RHN::Session)  
      1 perl(RHN::Set)  
      1 perl(RHN::Scheduler)  
      1 perl(RHN::SimpleStruct)  
      1 perl(RHN::StoredMessage) = 1.12
      1 perl(RHN::SystemSnapshot)  
      1 perl(RHN::Tag)  
      1 perl(RHN::TemplateString)  
      1 perl(RHN::TinyURL)  
      1 perl(RHN::Token)  
      1 perl(RHN::TSDB)  
      1 perl(RHN::User)  
      1 perl(RHN::Utils)  
      1 perl(RHN) = 0.04
      1 rhn-base = 5.3.0
      1 spacewalk-base = 1.6.14-1.fc15
      1 spacewalk(spacewalk-base-minimal) = 1.6.14-1.fc15
      1 spacewalk(spacewalk-base) = 1.6.14-1.fc15
../RPMS/noarch/spacewalk-dobby-1.6.14-1.fc15.noarch.rpm
      1 config(spacewalk-dobby) = 1.6.14-1.fc15
      1 perl(Dobby::BackupLog)  
      1 perl(Dobby::BackupLog::FileEntry)  
      1 perl(Dobby::BackupLog::TablespaceEntry)  
      1 perl(Dobby::CLI)  
      1 perl(Dobby::CLI::BackupCommands)  
      1 perl(Dobby::CLI::MaintCommands)  
      1 perl(Dobby::CLI::MiscCommands)  
      1 perl(Dobby::DB)  
      1 perl(Dobby::Files)  
      1 perl(Dobby::Log)  
      1 perl(Dobby::Reporting)  
      1 perl(Dobby) = 0.01
      1 rhn-dobby = 5.3.0
      1 spacewalk-dobby = 1.6.14-1.fc15
../RPMS/noarch/spacewalk-grail-1.6.14-1.fc15.noarch.rpm
      1 perl(Grail::Canvas)  
      1 perl(Grail::Component)  
      1 perl(Grail::Frame)  
      1 perl(Grail) = 0.01
      1 rhn-grail = 5.3.0
      1 spacewalk-grail = 1.6.14-1.fc15
../RPMS/noarch/spacewalk-html-1.6.14-1.fc15.noarch.rpm
      1 rhn-help = 5.3.0
      1 rhn-html = 5.3.0
      1 spacewalk-html = 1.6.14-1.fc15
../RPMS/noarch/spacewalk-pxt-1.6.14-1.fc15.noarch.rpm
      1 config(spacewalk-pxt) = 1.6.14-1.fc15
      1 perl(PXT::ACL)  
      1 perl(PXT::ApacheAuth)  
      1 perl(PXT::ApacheHandler)  
      1 perl(PXT::Config)  
      1 perl(PXT::Debug)  
      1 perl(PXT::Handlers)  
      1 perl(PXT::HTML)  
      1 perl(PXT::Parser)  
      1 perl(PXT::Request)  
      1 perl(PXT::Trace)  
      1 perl(PXT::Trace::DB)  
      1 perl(PXT::Trace::Hit)  
      1 perl(PXT::Utils)  
      1 perl(PXT) = 0.04
      1 rhn-pxt = 5.3.0
      1 spacewalk-pxt = 1.6.14-1.fc15
../RPMS/noarch/spacewalk-sniglets-1.6.14-1.fc15.noarch.rpm
      1 perl(Sniglets::ActivationKeys)  
      1 perl(Sniglets::AppInstall)  
      1 perl(Sniglets::ContactMethod)  
      1 perl(Sniglets::CustomInfo)  
      1 perl(Sniglets::Errata)  
      1 perl(Sniglets::ErrataEditor)  
      1 perl(Sniglets::Forms)  
      1 perl(Sniglets::Forms::Style)  
      1 perl(Sniglets::Forms::Style::kickstart)  
      1 perl(Sniglets::Forms::Style::namespace)  
      1 perl(Sniglets::Forms::Style::standard)  
      1 perl(Sniglets::Forms::Style::survey)  
      1 perl(Sniglets::Header)  
      1 perl(Sniglets::HTML)  
      1 perl(Sniglets::Channel)  
      1 perl(Sniglets::ChannelEditor)  
      1 perl(Sniglets::Kickstart)  
      1 perl(Sniglets::Lists)  
      1 perl(Sniglets::ListUtils)  
      1 perl(Sniglets::ListView::ActionList)  
      1 perl(Sniglets::ListView::ConfigChannelList)  
      1 perl(Sniglets::ListView::ContactMethodList)  
      1 perl(Sniglets::ListView::CustomInfo)  
      1 perl(Sniglets::ListView::ErrataList)  
      1 perl(Sniglets::ListView::ExtraClasses)  
      1 perl(Sniglets::ListView::FileList)  
      1 perl(Sniglets::ListView::GeneralList)  
      1 perl(Sniglets::ListView::ChannelList)  
      1 perl(Sniglets::ListView::List)  
      1 perl(Sniglets::ListView::PackageList)  
      1 perl(Sniglets::ListView::Parser)  
      1 perl(Sniglets::ListView::ProbeList)  
      1 perl(Sniglets::ListView::ProfileList)  
      1 perl(Sniglets::ListView::ScoutList)  
      1 perl(Sniglets::ListView::Style)  
      1 perl(Sniglets::ListView::Style::blank)  
      1 perl(Sniglets::ListView::Style::channel_tree)  
      1 perl(Sniglets::ListView::Style::standard)  
      1 perl(Sniglets::ListView::Style::your_rhn_summary)  
      1 perl(Sniglets::ListView::SystemGroupList)  
      1 perl(Sniglets::ListView::SystemList)  
      1 perl(Sniglets::ListView::TracerList)  
      1 perl(Sniglets::ListView::TracerList::HitDS)  
      1 perl(Sniglets::ListView::TracerList::SessionDS)  
      1 perl(Sniglets::ListView::UserList)  
      1 perl(Sniglets::Navi)  
      1 perl(Sniglets::Navi::Node)  
      1 perl(Sniglets::Navi::Parser)  
      1 perl(Sniglets::Navi::Style)  
      1 perl(Sniglets::Navi::Style::contentnav)  
      1 perl(Sniglets::Navi::Style::sidenav)  
      1 perl(Sniglets::Navi::Style::topnav)  
      1 perl(Sniglets::Navi::Style::ul)  
      1 perl(Sniglets::Navi::Tree)  
      1 perl(Sniglets::Packages)  
      1 perl(Sniglets::Profiles)  
      1 perl(Sniglets::Scouts)  
      1 perl(Sniglets::Search)  
      1 perl(Sniglets::ServerActions)  
      1 perl(Sniglets::ServerGroup)  
      1 perl(Sniglets::ServerNotes)  
      1 perl(Sniglets::Servers)  
      1 perl(Sniglets::Sets)  
      1 perl(Sniglets::Snapshot)  
      1 perl(Sniglets::Users)  
      1 perl(Sniglets::Utils)  
      1 perl(Sniglets) = 0.01
      1 rhn-sniglets = 5.3.0
      1 spacewalk-sniglets = 1.6.14-1.fc15

Binary dependencies resolvable. Ok.

Package builds in F17
(http://koji.fedoraproject.org/koji/taskinfo?taskID=3291115). Ok.

Otherwise package is in line with Fedora and Perl packaging guidelines.


Please correct all `FIX' prefixed issues and provide new spec file.

Resolution: Package NOT approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to