Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=733179

Volker Fröhlich <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #2 from Volker Fröhlich <[email protected]> 2011-08-30 18:16:19 EDT 
---
Don't ship INSTALL.

Defattr is no longer necessary, if you don't aim for EPEL4 or older.

Use the name macro in the files section. You can shorten the files section to:

%files
%doc AUTHORS ChangeLog COPYING LICENSE NEWS README TODO
%{_bindir}/%{name}
%{_datadir}/%{name}

Rpmlint:

filebench.x86_64: W: file-not-utf8 /usr/share/doc/filebench-1.4.9/LICENSE
filebench.x86_64: W: no-manual-page-for-binary filebench

At least Sun had some sort of manpage, as far as I can see.

Please change the encoding of the licensefile to UTF-8 in the first place.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to