Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674080 --- Comment #2 from Bohuslav Kabrda <[email protected]> 2011-09-07 06:43:31 EDT --- Errata: * The license is really MIT, sorry. Additional comments: * The first two lines (definition of %ruby_sitelib and %ruby_sitearch is not necessarry in this spec file. * Have you tested the app with Rails 3? * Consider using %dir %{geminstdir} instead of %{geminstdir} in files - it solves the problem with files being listed multiple times. * You should use ruby(rubygems) in Require instead of just rubygems. * Include BuildRequires: ruby. * The %defattr(-, root, root, -) in %files section is not needed. * You should include %check section and run the tests (something like RUBYOPT="I%{buildroot}%{geminstdir}/lib Itest" testrb test/*_test.rb should do). * Reference to koji task: https://koji.fedoraproject.org/koji/taskinfo?taskID=3332026 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
