Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=738525 --- Comment #2 from Mathieu Bridon <[email protected]> 2011-09-18 23:13:46 EDT --- Spec URL: http://bochecha.fedorapeople.org/packages/perl-ExtUtils-H2PM.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-ExtUtils-H2PM-0.08-1.fc14.src.rpm (In reply to comment #1) > MUST > - spelling-error need to be fixed Fixed. > - issue with %optimize [... snip ...] > I think you could probably remove it, except if you think you need it, if this > case, you must set it. So, I had never seen this macro either, but cpanspec was setting it so I trusted it. Digging a bit, here is what I get when I run the following: $ cpanspec ExtUtils::H2PM [... snip ...] %{__perl} Build.PL installdirs=vendor optimize="$RPM_OPT_FLAGS" [... snip ...] $ cpanspec -m ExtUtils::H2PM [... snip ...] %{__perl} Build.PL installdirs=vendor optimize="%{optimize}" [... snip ...] But then, as you observed: $ rpm --eval "%{optimize}" %{optimize} Is that a bug in cpanspec? For this particular package, should I remove it completely or replace it by "$RPM_OPT_FLAGS"? > SHOULD > - package latest version 0.08, released yesterday... ;) Done. Note that this fixes the incorrect FSF address in license. > - make %file more exclicite (I personally hate to wide joker) Fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
