Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=736051 Vít Ondruch <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #12 from Vít Ondruch <[email protected]> 2011-09-21 02:02:11 EDT --- (In reply to comment #2) > Review: > > <snip> > Requires: ruby(abi) = %{rubyabi} > .... > Requires: ruby > </snip> > > * Is this necessary? > * Is the %prep section necessary? I can't see any tests running there. In > %prep > you copy all gem files with gem install in one place and in %install you move > them to another. Why not use gem install in %install section? > * Remove the 'echo %{SOURCE0}' > * Is the rubygem(shoulda) really needed as a Runtime dependency? Don't that forget we have JRuby in Fedora now. If JRuby are going to provide ruby(abi) (and they should if they are not doing so yet), the it makes sense. However this is unfortunately gray area yet :/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
