Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674085 --- Comment #5 from Vít Ondruch <[email protected]> 2011-10-07 04:52:06 EDT --- If I may, I would suggest the following: * Remove unnecessary ruby_sitelib and ruby_sitearch globals, since they are not used for this gem. * The require should preferably use the virtual providers every Ruby package should have, i.e. use Requires: ruby(libvirt) and BuildRequires: ruby(rubygems) * The package should reference required ruby(abi) * The BuildRoot is obsolete * The clean section is not required * The %defattr macros are obsolete * It would be nice to use -doc subpackage for larger documentation * I always suggest to execute the test suite in the %check section to protect you, your users and possibly somebody else who will need to rebuild your package BTW have you updated the release number nor not? Or am I doing review on wrong srpm? But I took one from Koji [1] you reference ... [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=3410848 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
