Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=745515 Ville Skyttä <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] AssignedTo|[email protected] |[email protected] Flag| |fedora-review? --- Comment #1 from Ville Skyttä <[email protected]> 2011-10-15 14:17:49 EDT --- * LICENSE.TXT UTF-8 conversion should be from Windows-1252, not ISO-8859-1. * Use %ant instead of plain ant. * Upstream does not build or ship javadocs, should we? If you think it's a good idea, please use %javadoc instead of plain javadoc, and crosslink them with java javadocs (BuildRequires: java-javadoc + Requires: java-javadoc + %javadoc -link %{_javadocdir}/java). Also, drop "-subpackages org" - there's nothing in it that ends up in javadocs with the currently used options. * Add doc/README and doc/CHANGELOG to %docs. * rhino dep and build dep needs to be versioned: >= 1.7R3 * Please include a script in the srpm that can be used to recreate the tarball, for example like this one: http://pkgs.fedoraproject.org/gitweb/?p=reptyr.git;a=blob;f=reptyr-snapshot.sh;h=2edfe4e * Unlike upstream 2.4.6 release, the packaged version seems to have some comment related issues which I think are severe enough that they need to be fixed before the package can be included, for example: $ echo "/* hello */" | yuicompressor --type js [ERROR] 1:11:unterminated comment [ERROR] 1:0:Compilation produced 1 syntax errors. org.mozilla.javascript.EvaluatorException: Compilation produced 1 syntax errors. at com.yahoo.platform.yui.compressor.YUICompressor$1.runtimeError(YUICompressor.java:154) [...] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
