Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=738162

--- Comment #3 from Vít Ondruch <[email protected]> 2011-10-17 07:14:40 EDT 
---
* Please remove "testdir" macro
  - It seems it is not used anywhere

* Fix you name in ChangeLog
  - Please use your full name in ChangeLog

* Exclude the %{geminstdir}/doc from the package
  - It seems that this folder contains just the RDoc generated documentation.
    In this case, please exclude this folder, since we don't need to duplicate
    the documentation from generic RDoc location.

* The package doesn't work:

> require 'oauth_active_resource'
Gem::LoadError: Could not find activeresource (< 3.0.0) amongst
[activemodel-3.0.10, activeresource-3.0.10, activesupport-3.0.10,
builder-2.1.2, i18n-0.5.0, multipart-0.2.1, multipart-post-1.1.2, oauth-0.4.4,
oauth-active-resource-0.4.7]
 from /usr/lib/ruby/site_ruby/1.8/rubygems/dependency.rb:247:in `to_specs'
 from /usr/lib/ruby/site_ruby/1.8/rubygems/specification.rb:761:in
`activate_dependencies'
 from /usr/lib/ruby/site_ruby/1.8/rubygems/specification.rb:758:in `each'
 from /usr/lib/ruby/site_ruby/1.8/rubygems/specification.rb:758:in
`activate_dependencies'
 from /usr/lib/ruby/site_ruby/1.8/rubygems/specification.rb:742:in `activate'
 from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:209:in `try_activate'
 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:58:in `require'
 from (irb):4
 from /usr/lib/ruby/1.8/i386-linux/rbconfig.rb:159

  - since the package .gemspec file defines dependency on activeresource 
    (< 3.0.0), but Fedora provides just version 3.0.10, the gemspec file should
    be patched accordingly (you can take a look at [1] how to achieve that).
  - However note that it is not clear if the gem can cooperate with
    activeresource 3.0.10 at all.


[1] http://pkgs.fedoraproject.org/gitweb/?p=rubygem-actionpack.git;a=tree

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to