Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=746761 --- Comment #3 from Jon VanAlten <[email protected]> 2011-11-07 18:57:41 EST --- (In reply to comment #2) Thanks for the review! > === Issues === > 1. Install License file. Whoops! I have ensured that both main and -bson, -javadoc subpackages (since there is no dependency) install the LICENSE.txt file. I also added the README.md, for good measure. > 2. fix changelog Done. > 3. there is no need to specify noarch for every subpackage if the main one is > noarch Oh. That's great, have stripped relevant unnecessary lines from .spec. > 4. instead of cd and cp to/from mongodb-mongo-java-driver-ffe0029 it would be > nice to use %setup -q -n mongodb-mongo-java-driver-ffe0029 and effectively > make > it the buildroot Good idea, thanks. > 5. The two javadoc subpackages are broken because you don't have index and all > the rest of the file that make them browsable. Unless you can make the javadoc > be generated for the two subpackages in two different directories with all the > harness files you would have to create one single javadoc subpackage merging > the two current one. So true, careless on my part. I looked into what it would take to generate harness for each part, would need to change upstream build (which I am loath to do). So, have combined into single javadoc, for the time being. Upstream has hinted that they would like to change so that the bson part is more separate anyways, so in the longer term I will find out more about that. I've put updated files in same location: Spec URL: http://www.vanaltj.com/pkgreview/mongo-java-driver.spec SRPM URL: http://www.vanaltj.com/pkgreview/mongo-java-driver-2.6.5-1.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
