Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752829 --- Comment #2 from Steve Traylen <[email protected]> 2011-11-10 16:59:31 EST --- A first pass just looking at the .spec file: 1) The Source0: can't be located see: http://fedoraproject.org/wiki/Packaging:SourceURL 2) EGEE is I'm fairly positive an approved license 3) %setup is not -q'd 4) Changelog version numbers don't match 5) Vendor must never be present. 6) The INSTALLED_FILES trick with setup tools is unusual. There are some setuptools examples on the python guidelines page: http://fedoraproject.org/wiki/Packaging:Python Please pass your packages through rpmlint and reduce what it finds to a minimum. It will have found all of the above I expect. Become familiar with http://fedoraproject.org/wiki/Packaging:Guidelines and then provide new .spec and .src.rpm For the purposes of being sponsored then preferably submit at least another package for review and provide informal review or two to other pending reviews. Grab a pending review from here: http://fedoraproject.org/PackageReviewStatus/NEW.html Once you have done a review or two leave a link to it in this bug. Steve. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
