Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=749752

Richard Shaw <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #1 from Richard Shaw <[email protected]> 2011-11-12 15:18:50 EST 
---
Are you interested in a review swap? I need the following reviewed:

https://bugzilla.redhat.com/show_bug.cgi?id=753453

Here's my initial review:

1. You're missing a "BuildRequires: openssl-devel"

2. Unless it's required for EL (I'm a Fedora guy) using macros for basic
commands is discouraged. Just use make instead of the macro for make.

Richard

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to