Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752858

Parag AN(पराग) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
         AssignedTo|[email protected]    |[email protected]
               Flag|                            |fedora-review+

--- Comment #2 from Parag AN(पराग) <[email protected]> 2011-11-16 04:32:04 EST 
---
Review:-

+ koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3504521

+ rpmlint on a package gave
perl-Qt-devel.x86_64: W: file-not-utf8
/usr/share/doc/perl-Qt-devel-0.96.0/examples/tools/codecs/encodedfiles/iso-8859-1.txt
perl-Qt-devel.x86_64: E: wrong-script-interpreter
/usr/share/doc/perl-Qt-devel-0.96.0/examples/linguist/hellotr/hellotr.pro [0]
perl-Qt-devel.x86_64: W: file-not-utf8
/usr/share/doc/perl-Qt-devel-0.96.0/examples/tools/codecs/encodedfiles/iso-8859-15.txt
perl-Qt-devel.x86_64: W: no-manual-page-for-binary puic4
perl-Qt-devel.x86_64: W: no-manual-page-for-binary prcc4_bin
perl-Qt-devel.x86_64: W: no-manual-page-for-binary qdbusxml2perl
3 packages and 0 specfiles checked; 1 errors, 5 warnings.

+ Source verified with upstream as (sha1sum)
147428a10da852e82c0da06307c3c45ac8dada88  Qt-0.96.0.tar.gz
147428a10da852e82c0da06307c3c45ac8dada88  ../SOURCES/Qt-0.96.0.tar.gz

+ make test gave
100% tests passed, 0 tests failed out of 26
Total Test time (real) =   6.11 sec

+ Follows packaging guidelines

suggestions:
1) Fix the rpmlint warnings for file-not-utf8 for iso-8859-1.txt and
iso-8859-15.txt. See
http://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8

2) Fix the rpmlint error as given above.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to