Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754554 --- Comment #3 from Fabian Deutsch <[email protected]> 2011-11-17 10:06:40 EST --- Thanks for looking at it. (In reply to comment #2) > If you want to create tarball from git it's better to use "git archive" to do > it. Your "tar -cJvf presence-%{version}.tar.xz presence-%{version}" packs .git > directory as well. True. I wonder why I used tar in the first place. > Another thing: Upstream version is 0.4 not 0.4.1. Version numbers in Fedora > should match versions from upstream tarball. I know you are upstream, but it's > still better to be consistent. I actually pushed the tag for presence-0.4.1, this should match upstream. Or am I missing something? > License is also incorrect, COPYING file is LGPL 2.1, yet spec states GPLv2+. Ouch, will be fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
