Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=683790 --- Comment #6 from Jan Klepek <[email protected]> 2011-11-17 11:40:32 EST --- (In reply to comment #3) > - License is MIT. - Fixed > - The defined %ruby_sitelib macro is never used, so please remove it. - Fixed > - You should use %global instead of %define, according to [1]. - Fixed > - You don't need to specify BuildRoot tag, see [2] - I know, as there is still open possibility to have this for EPEL in future, I keep it there. > - Could you explain the Requires: rubygem(rubyforge) and Requires: > rubygem(gemcutter)? I don't see why the library wouldn't work without them. > - Simlarly, can you explain the BuildRequires: rubygem(yard)? I don't see what > you need yard for during the build. - Fixed BuildRequires on rubygem(yard) is there because build fail without it, due to [1] > - You don't need to use the "%defattr(-, root, root, -)" line, see [3] - Yes, I'm aware of that, however i prefer to keep it there > - Consider moving documentation into a subpackage (except of README.rdoc, > which contains licensing info and therefore should be left in the main > package). - Documentation is too small to put it into subpackage, not worth of effort. > - rpmbuild complains about History.rdoc and Manifest.txt listed twice. To > solve > it: > ** the package shouldn't own the whole %{gemdir}/gems/%{gemname}-%{version}/ > directory (BTW you can use %{geminstdir} instead of it), but should rather own > %dir %{geminstdir} > ** when you do that, you will need to add every subdirectory and file in > %{geminstdir} to %files, but you will be able to avoid the complaints about > files listed twice - Could not reproduce, works for me correctly (rpmlint-1.3.2). [1] https://github.com/postmodern/hoe-yard/issues/1 Spec URL: http://hpejakle.fedorapeople.org/packages/rubygem-hoe-yard.spec SRPM URL: http://hpejakle.fedorapeople.org/packages/rubygem-hoe-yard-0.1.2-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
