Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755054 Volker Fröhlich <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Volker Fröhlich <[email protected]> 2011-11-18 17:36:45 EST --- License is GPLv2+. The FSF address is wrong. Feel free to correct it and ask upstream to also do so. The description is not a manual. I suggest to remove the second paragraph. You can use the name and version macro for Source. Some people are opposed to using the name macro there though. %doc is usually right underneath %files. ABOUT-NLS has nothing to do with this package, I think. The changelog should depict what you changed in packaging. Rpmlint says, you're mixing spaces and tabs on line 8. Rpmlint also complains about your file not having a changelog entry, although it has one. Try to find out why that happens. I haven't seen that before. You can also shorten the BuildRequires a bit: For instance, GConf2-devel requires glib2-devel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
