Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751114

--- Comment #3 from Peter Lemenkov <[email protected]> 2011-11-21 11:42:13 EST 
---
(In reply to comment #2)
> Any update on this?

Hello, Justin. Sorry for the hiatus. Here are my preliminary suggestions:

* Please provide a way to recreate tarball. I advise you to add something like
this:

# svn export http://sgabios.googlecode.com/svn/trunk sgabios-0
# tar -cjvf sgabios-0.tar.bz2 sgabios-0

* Versioning is slightly wrong - release should be 0.

* You added ExclusiveArch directive but this application (BIOS firmware) is
intended to be used on every architecture which is supported by Qemu so this is
wrong. I changed it a bit and dropped splitting to main and *-bin subpackages.
Here is my variant:

* http://peter.fedorapeople.org/sgabios/sgabios.spec
* http://peter.fedorapeople.org/sgabios/sgabios-0-0.1.20110621SVN.fc16.src.rpm

Koji scratchbuild for Rawhide:

* http://koji.fedoraproject.org/koji/taskinfo?taskID=3529886

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to