Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=749291 --- Comment #8 from Steve Traylen <[email protected]> 2011-12-04 12:56:17 EST --- CFLAGS look good now. /usr/lib64/ccache/c++ -fPIC -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -shared -Wl,-soname,libXrdDPMXmi.so.2 -o libXrdDPMXmi.so.2.2.3 CMakeFiles/XrdDPMXmi.dir/XrdDPMXmi.cc.o CMakeFiles/XrdDPMXmi.dir/XrdDPMXmiQueueAndReq.cc.o -ldpm -lXrd there are some warnings you might like to submit upstream as improvements: /builddir/build/BUILD/dpm-xrootd-2.2.4/src/XrdDPMXmi.cc: In member function 'void XrdDPMXmi::InitXeq()': /builddir/build/BUILD/dpm-xrootd-2.2.4/src/XrdDPMXmi.cc:325: warning: suggest explicit braces to avoid ambiguous 'else' /builddir/build/BUILD/dpm-xrootd-2.2.4/src/XrdDPMXmi.cc: In member function 'void XrdDPMXmi::MSSPoll()': /builddir/build/BUILD/dpm-xrootd-2.2.4/src/XrdDPMXmi.cc:359: warning: deprecated conversion from string constant to 'char*' /builddir/build/BUILD/dpm-xrootd-2.2.4/src/XrdDPMXmi.cc: In member function 'int XrdDPMXmi::SetDefaultsAndReadConfig(XrdCmsXmiEnv*)': /builddir/build/BUILD/dpm-xrootd-2.2.4/src/XrdDPMXmi.cc:1640: warning: comparison between signed and unsigned integer expressions /builddir/build/BUILD/dpm-xrootd-2.2.4/src/XrdDPMXmi.cc: In function 'char* prefix_mad(const char*, char*, size_t)': /builddir/build/BUILD/dpm-xrootd-2.2.4/src/XrdDPMXmi.cc:1868: warning: comparison between signed and unsigned integer expressions Now installing the package and checking basics: Sorry I missed this earlier: /etc/init.d/dpm-cms /etc/init.d/dpm-manager-cms /etc/init.d/dpm-manager-xrd /etc/init.d/dpm-xrd should all be in %{_initrddir}. The various start up scripts look dodgy not to say the least: # service dpm-cms start Error: /opt/lcg/bin/dpm-cmsd does not exist # service dpm-manager-cms start Error: /opt/lcg/bin/dpm-manager-cmsd does not exist # service dpm-manager-xrd start Error: /opt/lcg/bin/dpm-manager-xrootd does not exist # service dpm-xrd start Error: /opt/lcg/bin/dpm-xrootd does not exist More over these all return 0. Please have default configurations work or at the very least return a sensible error code: http://fedoraproject.org/wiki/Packaging:SysVInitScript#Exit_Codes_for_non-Status_Actions -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
