Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=759855

--- Comment #10 from Christoph Wickert <[email protected]> 2011-12-17 
18:05:23 EST ---
When using install oc cp, please preserve timstamps, see
https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps

You are still compressing the manpage. Please don't, rpmbuild will do it
automatically. And don't use an extension (gz) in the %files section. We might
switch to bz or xz compression and then your spec will fail. Just
%{_mandir}/man8/sslh.8.* or %{_mandir}/man8/* is fine. 

Please use the macro %{_unitdir} instead of hardcoding /lib/systemd/system.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to