Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752829 Steve Traylen <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #22 from Steve Traylen <[email protected]> 2011-12-20 06:01:23 EST --- APPROVED but something I missed and a comment. Change: install -m 0644 man/glue-validator.1 %{buildroot}/usr/share/man/man1 to install -p -m 0644 man/glue-validator.1 %{buildroot}/usr/share/man/man1 to preserve the timestamp of the file from last edit. This is written down somewhere in the guidelines but I can't find it just now. Also a comment about your comments, e.g. - A couple of small spec file fixes is basically obvious , they could have more details about what changed so as to be useful to the end user. Steve. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
