Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769444 --- Comment #3 from Bohuslav Kabrda <[email protected]> 2011-12-21 07:30:20 EST --- - According to ruby naming guidelines [1], the name should be ruby-korundum. - License should be GPLv2+ and LGPLv2+: [bkabrda@localhost BUILD]$ licensecheck -r korundum-4.7.90/ | grep LGPL korundum-4.7.90/tools/rbkconfig_compiler/rbkconfig_compiler.cpp: LGPL (v2 or later) korundum-4.7.90/modules/akonadi/examples/akonamail/mainwidget.rb: LGPL (v2 or later) (also, see COPYING and COPYING.LIB, where GPLv2+, resp. LGPLv2+ are mentioned). - All the imports work only when you first require 'Qt', otherwise they throw "NameError: uninitialized constant QtWebKit::Internal::Qt" and similar. Because there is not much documentation available, I'm not sure if it should be that way or if it is bug. Could you please clarify this? - Also, one minority: Url should be uppercase, so URL :) - Otherwise, the package looks good, so when you correct these things, I think it will be ok. [1] https://fedoraproject.org/wiki/Packaging:Ruby#Naming_Guidelines -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
