Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770755 Mohamed El Morabity <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] AssignedTo|[email protected] |[email protected] --- Comment #1 from Mohamed El Morabity <[email protected]> 2011-12-29 05:22:27 EST --- I will review this package. Some comments for now: - about these lines: # The source for this package was pulled from upstream's git. Use the # following commands to generate the tarball: # git clone git://github.com/eonpatapon/gnome-shell-extension-calc.git # tar -czvf gnome-shell-extension-calc-2fca097.tar.gz gnome-shell-extension-calc Source0: %{name}-%{git}.tar.gz The command you give here to retrieve the source always gets the latest commit in the Git repository. You'd better give the way to obtain the sources *corresponding to the packaged commit*, as follows: $ git clone git://github.com/eonpatapon/gnome-shell-extension-calc.git $ cd gnome-shell-extension-calc/ $ git archive --format=tar --prefix=%{name}-%{git}/ %{git} | xz > ../%{name}-%{git}.tar.xz (I used xz instead of gzip to have smaller archives). Anyway, all of this is useless since you can retrieve from Github an archive of any commit you want. You can have a look a the gnome-shell-extension-icon-manager spec file as an example: http://pkgs.fedoraproject.org/gitweb/?p=gnome-shell-extension-icon-manager.git;a=blob_plain;f=gnome-shell-extension-icon-manager.spec;hb=f16 - about the license: the header comments in the extension.js file indicate a GPLv3 (or more) license: https://github.com/eonpatapon/gnome-shell-extension-calc/blob/master/extension.js You should update the License tag of your spec file to "GPLv2+". - %clean target and buildroot cleaning are not required anymore, you can remove them from your spec file: http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
