Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770283 Ivan Romanov <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from Ivan Romanov <[email protected]> 2011-12-31 11:25:05 EST --- Hi Tomaz. %clean stage can be dropped. https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag use %defattr(-,root,root,-) instead of %defattr(-,root,root) BuildRoot can be dropped. https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag Your package doesn't provide any .h files. But it provides -devel subpackage. I think you should use libuptimed/*.h Your package doesn't provide /etc/init.d/uptimed file. But it works with systemctl. I think rm -rf "%{buildroot}" can be dropped. Really this command always are doing when you use rpmbuild -bb some.spec Can you provide -static subpackage? It's not necessarily but would be more prefarable. For directories use %dir in %files. %dir %{_localstatedir}/spool/uptimed/ You must drop .la file https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
