Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769697 --- Comment #6 from Jussi Lehtola <[email protected]> 2012-01-04 14:56:58 EST --- I think you didn't quite understand what I said in comment #4. Please don't use macros for mv, rm and so on. They just make the spec file harder to read. ** Also, don't use mv to install files from the build directory to the buildroot. Use cp or install, instead. ** Be sure to preserve time stamps using the -p switch to cp and install. ** Please break %install into columns, it's a mess. ** Also, please separate the %clean section from %install. ** Last, you need to properly install the desktop file as in http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
