Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771842

Parag AN(पराग) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[email protected]    |[email protected]
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Parag AN(पराग) <[email protected]> 2012-01-06 03:30:35 EST 
---
Review:

+ koji scratch build
->http://koji.fedoraproject.org/koji/taskinfo?taskID=3621205

+ rpmlint on rpms gave
 navilu-fonts.noarch: W: spelling-error Summary(en_US) opentype -> open type,
open-type, phenotype
navilu-fonts.noarch: W: spelling-error %description -l en_US opentype -> open
type, open-type, phenotype
navilu-fonts.src: W: spelling-error Summary(en_US) opentype -> open type,
open-type, phenotype
navilu-fonts.src: W: spelling-error %description -l en_US opentype -> open
type, open-type, phenotype
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ source verified with upstream as (sha1sum)
eb71807bdfcc479ad5eac07d18da82100a2fd349  navilu-1.1.tar.gz
eb71807bdfcc479ad5eac07d18da82100a2fd349  ../SOURCES/navilu-1.1.tar.gz

+ follows fonts packaging guidelines


Suggestions
1) you should drop the versioned dependency. Change
BuildRequires: fontforge >= 20080429
to
BuildRequires: fontforge

2)you don't need to clean buildroot now. remove following from spec
BuildRequires: fontforge >= 20080429


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to