Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769096 Mohamed El Morabity <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[email protected] |[email protected] --- Comment #11 from Mohamed El Morabity <[email protected]> 2012-01-10 18:31:52 EST --- You don't have to use two %install targets per extension (and it doesn't work anyway, as you have seen). All you have to do is to merge them, as below: %install # Install windowoverlay-icons extension mkdir -p %{buildroot}%{_datadir}/gnome-shell/extensions/%{wiuuid} install -Dp -m 0644 windowoverlay-icons/{extension.js,metadata.json,stylesheet.css} \ %{buildroot}%{_datadir}/gnome-shell/extensions/%{wiuuid}/ # Install historymanager-prefix-search extension mkdir -p %{buildroot}%{_datadir}/gnome-shell/extensions/%{hpsuiid} install -Dp -m 0644 historymanager-prefix-search/{extension.js,metadata.json,stylesheet.css} \ %{buildroot}%{_datadir}/gnome-shell/extensions/%{hpsuuid}/ Don't forget also to set a %description for the package; there are only descriptions for each extension. Even if there is no gnome-shell-extension-sustmi package build in fact, a description is needed for the source RPM; for example: [...] BuildArch: noarch Requires: gnome-shell %description This package provides two GNOME Shell extensions, windowoverlay-icons and historymanager-prefix-search %package windowoverlay-icons [...] You can drop the buildroot cleaning, as well as the %defattr macro: http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean Be careful, the macro %{github} used in %prep is no more defined in your latest .spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
