Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781687 Orcan Ogetbil <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] AssignedTo|[email protected] |[email protected] Flag| |fedora-review? --- Comment #1 from Orcan Ogetbil <[email protected]> 2012-01-16 23:23:32 EST --- I reviewed this package. It is mostly fine. There are a few minor issues. Stuff marked with "does no harm" are just my remarks. Those are not strictly required to be changed. ! Please include the file NEWS in %doc umentation * rpmlint says: lv2-ui-debuginfo.x86_64: E: empty-debuginfo-package We should probably disable this via %global debug_package %{nil} lv2-ui.x86_64: E: no-binary lv2-ui.x86_64: W: only-non-binary-in-usr-lib lv2-ui-devel.x86_64: W: dangling-relative-symlink /usr/include/lv2/lv2plug.in/ns/extensions/ui ../../../../../lib64/lv2/ui.lv2 lv2-ui-devel.x86_64: W: no-documentation Ignore the above four lv2-ui.x86_64: W: no-documentation See above (NEWS file) - BR: pkgconfig not required. They don't do harm though - R: pkgconfig not required. No harm either ? Does this %{_libdir}/lv2/ui.lv2 need to be %dir %{_libdir}/lv2/ui.lv2 The former will include everything inside the directory, but you are also including the individual files inside the directory later on. * /usr/include/lv2/lv2plug.in/ns/extensions/ remains unowned. Should lv2core own this or should this package? ! These %post -p /sbin/ldconfig %postun -p /sbin/ldconfig should probably be removed. We are not placing anything directly in %_libdir (or in any other ld search path) - We don't compile anything, thus # Enforce Fedora specific build flags sed -i 's|c99|c99 %{optflags}|' wscript seems irrelevant. Does no harm though. - rm -rf %{buildroot} is not required anymore. Does no harm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
