Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=782225 --- Comment #11 from David Nalley <[email protected]> 2012-01-18 13:59:56 EST --- (In reply to comment #7) > This is first java package I have reviewed, so forgive my ignorance here: > line 23-24: > > Requires(post): jpackage-utils > Requires(postun): jpackage-utils > > Requirement says "Package _DOES NOT_ have Requires(post/postun) on > jpackage-utils > > There is clearly a requires on jpackage-utils in the post/postun section > > line 43-47: > > %post > %update_maven_depmap > > %postun > %update_maven_depmap > > Requirement says "Package _DOES NOT_ use %update_maven_depmap in > %post/%postun" > > They are clearly used in these sections. > > Since java is out of my area of expertise (I normally review python/c > packages), if you can find a confident java packager to signoff on this > portion, obtain an exception from the java sig, or have someone from the java > sig educate me on the rationale for these requirements, I'd be happy to > approve > the package. > > Regards > -steve Well - I fail. Not only do I fail to adhere to the guidelines, I apparently can't read either. Fixed here: SRPM: http://ke4qqq.fedorapeople.org/ehcache-parent-2.3-2.fc16.src.rpm SPEC: http://ke4qqq.fedorapeople.org/ehcache-parent.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
