Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=790112 Stephen Gallagher <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] AssignedTo|[email protected] |[email protected] Flag| |fedora-review+ --- Comment #4 from Stephen Gallagher <[email protected]> 2012-02-13 15:15:05 EST --- I'm acking this review with only one (non-mandatory) recommendation. Instead of %{_includedir}/* it would be a good idea to list the headers explicitly so in the future if you grow a new public header, it won't be included accidentally. (Or if you accidentally stop installing one in the right location, you'll know immediately). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
