Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=790347 --- Comment #1 from Haïkel Guémar <[email protected]> 2012-02-14 05:52:04 EST --- Few minor changes: * remove the following macros which is unneeded %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} * you should filter python native module provides, adding the following snippet in your spec should be enough %{?filter_setup: %filter_provides_in %{python_sitearch}/.*\.so$ %filter_setup } * you should also set minimal versions for dependencies (look for configure.ac) gsoap-devel >= 2.7.13 swig >= 1.3.0 * i recommend that new packages use macro-style macros over shell-style (not mandatory) sed -i 's/$RPM_BUILD_ROOT/%{buildroot}/g' Apart these, everything looks good, as soon as you fix these, i'll start the formal review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
