Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=782560

--- Comment #4 from Bohuslav "Slavek" Kabrda <[email protected]> 2012-02-15 
02:14:22 EST ---
(In reply to comment #3)
> Wouldn't Obsoletes: ruby(shadow) < 1.4.1-16 be better?  1.4.1-15.fc18 was the
> last version of the old package in Fedora and EPEL AFAICT.
> 
> Similarly, I think:
> 
>   Obsoletes:      ruby-shadow >= 1.4.1
>   Provides:       ruby-shadow >= 1.4.1
> 
> should be more like:
> 
>   Obsoletes:      ruby-shadow < 1.4.1-16
>   Provides:       ruby-shadow = %{version}-%{release}
> 

Well, the guidelines for obsoleting are pretty clear, so it should really be
the way I mentioned in comment2.

> Is the '*' in the summary going to make life interesting for folks searching
> via yum?  Maybe 'Ruby shadow password module' is good?
> 

That's probably a good point :) Michael, I think that you should fix this (but
not a blocker on my side).

> (Just some comments from the peanut gallery. Thanks for packaging this Mike,
> and thanks for the review Bohuslav. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to