Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=796183 --- Comment #3 from Petr Šplíchal <[email protected]> 2012-02-22 09:35:33 EST --- (In reply to comment #2) > - URL should probably point to [1], which contains some information about the > project, not the directory with source files/tars/etc... Agree, I've updated the link. > - You should use "install -p" to preserve timestamps, see [2]. Fixed. > - You cannot own %{python_sitelib} - that would imply that you own the whole > directory with any files _even from other packages_ (and after uninstallation > of your package, it would remove this directory with everything inside it). > Rather than that, use %{python_sitelib}/*, which will cause your package to > own > all the files that are under %{buildroot}%{python_sitelib}. Oh, I had that before but then "simplified" it in the wrong direction. This is now fixed as well. > - Otherwise the package looks good and works, so when you fix these problems, > it can be approved. Thanks for the review! New spec file and source rpm are ready: http://psss.fedorapeople.org/python-nitrate/python-nitrate.spec http://psss.fedorapeople.org/python-nitrate/python-nitrate-0.7-2.el6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
