Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=799171

Daniel Berrange <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Daniel Berrange <[email protected]> 2012-03-06 08:47:10 
EST ---
Changes look good. Approved. Though not required by packaging guidelines, I'd
still recommend you also make the following tweak:

Also avoid hardcoding  '.gz' on the end of man page paths, eg replace

   %{_datadir}/man/man1/ovs-benchmark.1.gz

with

   %{_datadir}/man/man1/ovs-benchmark.1*

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to