Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=800294 Thomas Spura <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] AssignedTo|[email protected] |[email protected] Flag| |fedora-review? --- Comment #1 from Thomas Spura <[email protected]> 2012-03-06 18:18:03 EST --- Review: - license ok (a LICENSE file would be great...) - name ok - url ok - noarch ok - no libs - no *.la Blocker: - Don't you want to R: python-django, once the main Django has it's new name? That would be more consistent to use the proper python-django package and not the provides Django from there. Review request is at: bug #737293 - obsoletes is wrong: There is a django-piston = 0.2.3-1, but you only obsolete anything below it, so correct would be: Obsoletes: %{pkgname} < 0.2.3-2 More info about that also here: https://fedoraproject.org/wiki/User:Bkabrda/Django_rename - Please remove the shipped egg in %prep, so you are sure it's not used. SHOULD: - Could you please be more specific in %files, e.g.: %{python_sitelib}/piston/ %{python_sitelib}/django_piston-%{version}-py?.?.egg-info/ This way you'll notice when the egg cannot be build. - defattr can be left out as you don't seem to be targeting EL < 6 - I wouldn't consider PKG-INFO as doc and it's in the egg anyway. It's more important to query upstream to include a proper LICENSE file. - Maybe it's possible to add a %check section? I know too less about django, this didn't get very far "DJANGO_SETTINGS_MODULE=piston nosetests -v piston". Maybe you can have a look. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
