Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=807375

Rex Dieter <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?([email protected]
                   |                            |)

--- Comment #4 from Rex Dieter <[email protected]> 2012-03-27 15:35:39 EDT 
---
So, in addition to stuff in comment #1 and comment #2 (lets consider that item
2), also:

3.  MUST:  Source0 not a full URL.  (maybe because it's not referring to an
official release... yet?).  If so, please say so in a comment in the .spec


naming: ok

license: ok

sources: NOT ok, cannot verify (see 3)

macros: ok

scriptlets: ok


4.  MUST %files
change
%{_kde4_appsdir}/%{name}/*
to
%{_kde4_appsdir}/%{name}/
else the parent dir isn't properly owned


So, fixup items 1-4, and I think we're good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to