Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=799651 --- Comment #13 from Sergio Monteiro Basto <[email protected]> 2012-03-28 15:12:42 EDT --- Spec URL: http://www.serjux.com/smb4k/smb4k.spec SRPM URL: http://www.serjux.com/smb4k/16/smb4k-1.0.1-3.fc16.src.rpm Hi, (In reply to comment #12) > Re: 4 > then please use > BuildRequires: kdelibs4-devel >= 4.4 > though I'd still argue the 4.4 is not needed, all versions of fedora shipping > now satisfy that. Done, one rpm is not just for our systems, could be useful for RHEL and friends and even in other different distros, so accurate information is good . > Re: 5 > I'm arguing just remove that snippet about links from the .spec altogether. > It's not needed, and just clutters and complicates the .spec anyway the snippet is removed. But still the question, is not better a relative link ? , I will try do it upstream. > Re: 6 > I see no explanation or documented reasons for > --add-category Network > --add-category FileTransfer > --add-category FileManager > did I overlook something? > > A simple comment in the .spec near the desktop-file-install call would be > sufficient. Done ah need a explanation or documented reasons . I change to "Network, KDE and utilities". I document that, previous categories was not made by me! > did I overlook something? I think not -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
