Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768700

--- Comment #4 from Kalpa Welivitigoda <[email protected]> 2012-03-30 
12:33:21 EDT ---
Hi Ankur thanks for the review. Here are the new files, hope now it is good to
go.

This runs in sugar-emulator so there's no need of a desktop file.

Group, although not standard it is the one for sugar activities.

Sugar packaging guide doesn't say about excluding setup.py. Perhaps if it is
there children who use the activity can see it's source and learn. That may be
the reason.

Spec URL: http://callkalpa.fedorapeople.org/sugar-flip/sugar-flip.spec
SRPM URL:
http://callkalpa.fedorapeople.org/sugar-flip/sugar-flip-1-2.fc16.src.rpm

rpmlint sugar-flip.spec ../SRPMS/sugar-flip-1-2.fc16.src.rpm
../RPMS/noarch/sugar-flip-1-2.fc16.noarch.rpm 
sugar-flip.spec:6: W: non-standard-group Sugar/Activities
sugar-flip.src: W: non-standard-group Sugar/Activities
sugar-flip.noarch: W: non-standard-group Sugar/Activities
2 packages and 1 specfiles checked; 0 errors, 3 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to