Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768538

Jon Ciesla <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
         AssignedTo|[email protected]    |[email protected]
               Flag|                            |fedora-review?

Bug 768538 depends on bug 754245, which changed state.

Bug 754245 Summary: Review Request: ocaml-menhir - LR(1) parser generator for 
OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=754245

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED
             Status|MODIFIED                    |ON_QA
         Resolution|                            |ERRATA
             Status|ON_QA                       |CLOSED

--- Comment #1 from Jon Ciesla <[email protected]> 2012-04-09 16:18:17 EDT 
---
Good:

- rpmlint checks return: 

why3.src: W: spelling-error %description -l en_US provers -> proves, rovers,
proverbs
The value of this tag appears to be misspelled. Please double-check.

Ignore.

why3-emacs.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

why3-emacs-el.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

why3-xemacs.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

why3-xemacs-el.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

why3.x86_64: W: no-manual-page-for-binary why3-cpulimit
Each executable in standard binary directories should have a man page.

why3.x86_64: W: no-manual-page-for-binary why3ml
Each executable in standard binary directories should have a man page.

why3.x86_64: W: no-manual-page-for-binary why3config
Each executable in standard binary directories should have a man page.

why3.x86_64: W: no-manual-page-for-binary why3bench
Each executable in standard binary directories should have a man page.

why3.x86_64: W: no-manual-page-for-binary why3
Each executable in standard binary directories should have a man page.

why3.x86_64: W: no-manual-page-for-binary why3realize
Each executable in standard binary directories should have a man page.

why3.x86_64: W: no-manual-page-for-binary why3replayer
Each executable in standard binary directories should have a man page.

why3.x86_64: W: no-manual-page-for-binary why3doc
Each executable in standard binary directories should have a man page.

why3.x86_64: W: no-manual-page-for-binary why3ide
Each executable in standard binary directories should have a man page.

why3-all.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

why3-coq.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

Fix if possbile, examine at least.

- package meets naming guidelines
- package meets packaging guidelines
- license ( LGPLv2 with exceptions ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR

Mock rawhide build fails, missing BuildRequires on sqlite-devel.  After that
it's fine.

- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Comment on why debuginfo is disabled, or enable it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to