Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=800105 Tomas Edwardsson <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Tomas Edwardsson <[email protected]> 2012-04-16 21:05:58 EDT --- This is a informal review MUST Rpmlint output is silent. [OK] rpmlint perl-Net-Google-Calendar-1.0-1.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint perl-Net-Google-Calendar-1.0-1.fc17.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. MUST: Buildroot is not present [FIX] You should remove Buildroot unless you plan on inclusion in EPEL5. See http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag MUST: Each %files section contains %defattr if [FIX] rpm < 4.4. Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed. You should remove %defattr unless you plan on inclusion in EPEL5. MUST: Package is licensed with an open-source [FIX] compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. There is no indication in the source of how the code is licensed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
