Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812674 --- Comment #7 from Richard Shaw <[email protected]> 2012-04-18 16:51:05 EDT --- (In reply to comment #6) > > 2. I've never seen desktop-file-validate put in %check. I think that's > > usually > > for "make test" type unit testing to kill builds that fail their tests even > > if > > they build. I usually put it in %install. > > There's a section in the packaging guidelines which explicitly says that it's > fine to place it in either %check or %install. In any case, we want the build > to fail if the validation fails, what's the whole point of using > desktop-file-validate. > > "one MUST run /.../ desktop-file-validate (in %check or %install)" Hmmm... never noticed that before! > Scratch build for rawhide with new gnome-doc-utils in buildroot: > http://koji.fedoraproject.org/koji/taskinfo?taskID=4003063 > > gnome-doc-utils update if you want to try and give karma: > https://admin.fedoraproject.org/updates/gnome-doc-utils-0.20.10-2.fc17 I'll try it in an F17 mock build (since I was using rawhide). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
