Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=808881 Paul Howarth <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] AssignedTo|[email protected] |[email protected] Flag| |fedora-review? --- Comment #1 from Paul Howarth <[email protected]> 2012-04-19 09:05:49 EDT --- Quick first pass comments: * Latest upstream is 0.43 * No point having BR: Test::Perl::Critic unless you also set AUTHOR_TESTING * No point having BR: Pod::Coverage::TrustPod/Test::Pod/Test::Pod::Coverage unless you also set RELEASE_TESTING * BR: Test::Script isn't really needed because there are no scripts to test * You don't need to remove empty directories from the buildroot * Does use of the %{__perl} macro buy us anything? * Similarly, %{?perl_default_filter} does nothing, but causes no harm either None of these are blockers so if you like I'll do a formal review of the package as it stands, or if you want to update to the latest upstream I'll wait until then. I just updated my local upstream release monitoring script to use this module. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
