Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=810335 Germán Racca <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Germán Racca <[email protected]> 2012-04-20 10:29:25 EDT --- Hi Ralph, just some quick comments: 1) Why you don't use macros in the spec file? Instead of writing: Source0: http://lobstertech.com/media/file/fabulous/fabulous-0.1.5.tar.gz you should use: Source0: http://lobstertech.com/media/file/%{modname}/%{modname}-%{version}.tar.gz so you don't need to update this line every time you bump the sepc file and avoid compiling an old source by mistake. 2) I also don't see the definition of sitelib for noarch packages at the top of the spec file, as indicated in the template /etc/rpmdevtools/spectemplate-python.spec. Is it not needed anymore? HTH, Germán. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
