Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812538 --- Comment #3 from Jason Tibbitts <ti...@math.uh.edu> 2012-04-20 17:26:07 EDT --- OK, this builds fine (on rawhide); rpmlint has only one complaint: herbstluftwm.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/herbstclient-completion This is fine; those files shouldn't be there, but that's not your fault. The project makefile is annoying; it hides the actual compiler call (so we can't verify the compiler flags it is using), does not provide a verbose mode and inserts control sequences which look more like line noise in the build logs. I had to build with a quick patch to get that done properly: diff -up ./rules.mk.orig ./rules.mk --- ./rules.mk.orig 2012-04-20 16:05:30.840050949 -0500 +++ ./rules.mk 2012-04-20 16:05:44.030637343 -0500 @@ -4,18 +4,14 @@ all: $(TARGET) rb: clean all $(TARGET): $(OBJ) - $(call colorecho,LD,$(TARGET)) - @$(LD) -o $@ $(LDFLAGS) $(OBJ) $(LIBS) + $(LD) -o $@ $(LDFLAGS) $(OBJ) $(LIBS) $(SRCDIR)/%.o: $(SRCDIR)/%.c $(HEADER) - $(call colorecho,CC,$<) - @$(CC) -c $(CFLAGS) -o $@ $< + $(CC) -c $(CFLAGS) -o $@ $< clean: - $(call colorecho,RM,$(TARGET)) - @rm -f $(TARGET) - $(call colorecho,RM,$(OBJ)) - @rm -f $(OBJ) + rm -f $(TARGET) + rm -f $(OBJ) info: @echo Some Info: and the result is that indeed, the package isn't built with the proper Fedora compiler flags. Unfortunately the makefile doesn't allow you to pass your own, so I used the following in %prep: sed -i -e 's/^CFLAGS =.*/CFLAGS = %{optflags} -std=c99 -pedantic ${INCS} -D _XOPEN_SOURCE=600/' config.mk Still seems to build after that but you'll need to do some testing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
