Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=809114 --- Comment #12 from Mohamed El Morabity <[email protected]> 2012-04-26 05:31:40 EDT --- Sorry for the late answer, I had quite a lot of work these last days. The systemd file looks fine to me, but the specific scriptlets are missing. You can have a look at this page to fix it: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd Since you will make this package available for EL, you'll need a SysV service file too. Do you intend to provide different spec files for EL and Fedora branches, or to use a unique spec file with version conditions? Be careful no to mix macro and variable style in your spec file: you should not use %{optflags} and $RPM_BUILD_ROOT together: http://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS The Provides you set is a really good idea, but don't forget to specify also the release to avoid any ambiguity in the dep solving: Provides: novacomd = %{version}-%{release} Once these issues fixed I will approve at last this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
