Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=801077 --- Comment #5 from Parag AN(पराग) <[email protected]> 2012-04-27 02:16:56 EDT --- 1) Are you going to push this for EPEL? If not then a) %clean section (see http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean) b) removal of buildroot in %install (remove line rm -rf $RPM_BUILD_ROOT) c) remove line %defattr(-,root,root,-) 2) Missing Requires: fcitx 3) rpmlint on rpms gave fcitx-libpinyin.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 5) fcitx-libpinyin.src: W: invalid-url Source0: http://fcitx.googlecode.com/files/fcitx-libpinyin-0.1.1_dict.tar.xz HTTP Error 404: Not Found fcitx-libpinyin.x86_64: E: incorrect-fsf-address /usr/share/doc/fcitx-libpinyin-0.1.1/COPYING 2 packages and 0 specfiles checked; 1 errors, 2 warnings. ==> as shown above comment1, you can fix mixed-use-of-spaces-and-tabs and for incorrect-fsf-address, you can ask upstream to change the address. invalid-url warning can be ignored. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
