Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=816126 --- Comment #1 from David Brown <[email protected]> 2012-04-30 11:08:54 EDT --- You have a patch for rhel <= 5 but no %clean for rhel 5 you should add that and put a similar %if macro around it. http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean Also, it looks like you are using the installed files feature of python. This page has a note about why doing that doesn't work out well. http://fedoraproject.org/wiki/Packaging:Python#Byte_compiling Explicitly stating the files and directories installed is more helpful to specfile readers to know what's actually getting installed by what rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
