Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=817597 Jussi Lehtola <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from Jussi Lehtola <[email protected]> 2012-05-03 07:00:50 EDT --- Explicit library requires are forbidden. Drop them. http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires ** cp %{_sourcedir}/%{name}.6.gz %{_builddir} This should read cp -p %{SOURCE1} . ** echo -e "8c8\n< Icon=luola.png\n---\n> Icon=luola" | patch luola.desktop - If you are patching, please create a proper patch. ** Please use the -p flag with install, so that time stamps are preserved. ** install -D %{name}.desktop %{buildroot}/%{_datadir}/applications/%{name}.desktop -m 0644 This is wrong. You need to use desktop-file-install (or desktop-file-validate). http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files ** Are you a member of the packagers group? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
