Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=799597

Johan Cwiklinski <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #2 from Johan Cwiklinski <[email protected]> 2012-05-06 11:46:18 EDT 
---
REVIEW : 
+ rpmlint is ok
 % rpmlint -i /var/lib/mock/fedora-16-x86_64/result/*.rpm
php-pecl-xhprof.src: W: spelling-error %description -l en_US profiler ->
profile, profiles, profiled
The value of this tag appears to be misspelled. Please double-check.

php-pecl-xhprof.x86_64: W: spelling-error %description -l en_US profiler ->
profile, profiles, profiled
The value of this tag appears to be misspelled. Please double-check.

xhprof.noarch: W: spelling-error %description -l en_US profiler -> profile,
profiles, profiled
The value of this tag appears to be misspelled. Please double-check.

xhprof.noarch: W: spelling-error %description -l en_US pecl -> peck, peel, pecs
The value of this tag appears to be misspelled. Please double-check.

xhprof.noarch: W: spelling-error %description -l en_US html -> HTML, ht ml,
ht-ml
The value of this tag appears to be misspelled. Please double-check.

4 packages and 0 specfiles checked; 0 errors, 5 warnings.

+ package is named according to the  Package Naming Guidelines .
+ spec file name ok
+ The package meet the Packaging Guidelines and PHP Guidelines
+ license ok (ASL) and match upstream
+ license provided
+ spec file is legible
+ sources match upstream
ae40b153d157e6369a32e2c1a59a61ec  xhprof-0.9.2.tgz
+ source URL ok
+ build on F16 x86_64 (php 5.3.10)
+ build on mock
+ BuildRequires
+ no locale
+ no shared library (extension are not lib.)
+ no system library
+ own all directories that it creates
+ not list a file more than once in the spec 
+ Permissions on files are set properly.
+ %clean ok
+ consistently use macro
+ contain code
+ small doc, no sub package
+ doc not required to run
+ no -devel
+ no -static
+ no .pc
+ no .la
+ not own files or directories already owned by other packages
+ %install start with rm -rf $RPM_BUILD_ROOT
+ all files are UTF-8
+ %check ok (only load test)
+ load in httpd ok
+ test ok (after install)
+ scriptlet ok

***** APPROVED *****

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to